fix issue (#7152 : Improve relation empty states on record page) #7157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
falgunmpatel
commented
Sep 19, 2024
falgunmpatel
commented
- "No xxx" removed for empty relations
- All(0) removed
… page) - "No xxx" removed for empty relations - All(0) removed
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request addresses issue #7152 by improving the empty state display for relation records on the record page.
- Removed
RecordDetailRelationRecordsListEmptyStatecomponent, eliminating 'No xxx' messages for empty relations - Modified
RecordDetailRelationSectionto hide 'All (0)' link when there are no records - Updated rendering logic in
RecordDetailRelationSectionfor a cleaner display of relation records list - Changes align with UX improvement goals by reducing redundant information for empty states
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
...s/object-record/record-show/record-detail-section/components/RecordDetailRelationSection.tsx
Show resolved
Hide resolved
|
Thanks @falgunmpatel
|
|
Thanks for your review @Bonapara . I will keep these points in my mind while solving any issues. Also I will rectify my mistakes in this issue soon. |
- make spaces even for empty records - display icons for empty records while keeping them on hover for other records
Also should I delete the component that I commented. |
bosiraphael
reviewed
Sep 20, 2024
There was a problem hiding this comment.
Hello @falgunmpatel ! Thank you for your contribution :) LGTM, just remove the unused component
Comment on lines
2
to
37
| import styled from '@emotion/styled'; | ||
| import { useIcons } from 'twenty-ui'; | ||
| //TODO : File no longer needed, after solving (issue: #7152 :- Improve relation empty states on record page) | ||
|
|
||
| import { ObjectMetadataItem } from '@/object-metadata/types/ObjectMetadataItem'; | ||
| // import { useTheme } from '@emotion/react'; | ||
| // import styled from '@emotion/styled'; | ||
| // import { useIcons } from 'twenty-ui'; | ||
|
|
||
| type RecordDetailRelationRecordsListEmptyStateProps = { | ||
| relationObjectMetadataItem: ObjectMetadataItem; | ||
| }; | ||
| // import { ObjectMetadataItem } from '@/object-metadata/types/ObjectMetadataItem'; | ||
|
|
||
| const StyledRelationRecordsListEmptyState = styled.div` | ||
| color: ${({ theme }) => theme.font.color.light}; | ||
| align-items: center; | ||
| justify-content: center; | ||
| gap: ${({ theme }) => theme.spacing(2)}; | ||
| display: flex; | ||
| height: ${({ theme }) => theme.spacing(10)}; | ||
| text-transform: capitalize; | ||
| `; | ||
| // type RecordDetailRelationRecordsListEmptyStateProps = { | ||
| // relationObjectMetadataItem: ObjectMetadataItem; | ||
| // }; | ||
|
|
||
| export const RecordDetailRelationRecordsListEmptyState = ({ | ||
| relationObjectMetadataItem, | ||
| }: RecordDetailRelationRecordsListEmptyStateProps) => { | ||
| const theme = useTheme(); | ||
| // const StyledRelationRecordsListEmptyState = styled.div` | ||
| // color: ${({ theme }) => theme.font.color.light}; | ||
| // align-items: center; | ||
| // justify-content: center; | ||
| // gap: ${({ theme }) => theme.spacing(2)}; | ||
| // display: flex; | ||
| // height: ${({ theme }) => theme.spacing(10)}; | ||
| // text-transform: capitalize; | ||
| // `; | ||
|
|
||
| const { getIcon } = useIcons(); | ||
| const Icon = getIcon(relationObjectMetadataItem.icon); | ||
| // export const RecordDetailRelationRecordsListEmptyState = ({ | ||
| // relationObjectMetadataItem, | ||
| // }: RecordDetailRelationRecordsListEmptyStateProps) => { | ||
| // const theme = useTheme(); | ||
|
|
||
| return ( | ||
| <StyledRelationRecordsListEmptyState> | ||
| <Icon size={theme.icon.size.sm} /> | ||
| <div>No {relationObjectMetadataItem.labelSingular}</div> | ||
| </StyledRelationRecordsListEmptyState> | ||
| ); | ||
| }; | ||
| // const { getIcon } = useIcons(); | ||
| // const Icon = getIcon(relationObjectMetadataItem.icon); | ||
|
|
||
| // return ( | ||
| // <StyledRelationRecordsListEmptyState> | ||
| // <Icon size={theme.icon.size.sm} /> | ||
| // <div>No {relationObjectMetadataItem.labelSingular}</div> | ||
| // </StyledRelationRecordsListEmptyState> | ||
| // ); | ||
| // }; |
There was a problem hiding this comment.
You can remove this component :)
|
Thanks @falgunmpatel! Could you adjust the skeleton loading by removing the relations skeleton? It causes too much flashing since we don't know if they will have content or not. Before
Desired
|
- Remove unused code for empty state in record detail relation records list
|
@Bonapara I have removed skeletons causing flashing effect and achieved desired output. Also, I have removed unused components. |
bosiraphael
reviewed
Sep 23, 2024
...s/object-record/record-show/record-detail-section/components/RecordDetailRelationSection.tsx
Outdated
Show resolved
Hide resolved
…cord-detail-section/components/RecordDetailRelationSection.tsx Co-authored-by: Raphaël Bosi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.