Activate/Deactivate workflow and Discard Draft #7022

Devessier · 2024-09-13T16:23:43Z

Setup

This PR can be tested only if some feature flags have specific values:

IsWorkflowEnabled equals true
IsQueryRunnerTwentyORMEnabled equals false

These feature flags weren't committed to don't break other branches.

What this PR brings

Display buttons to activate and deactivate a workflow version and a button to discard the current draft version. I also scaffolded a "Test" button, which doesn't do anything for now.
Wired the activate, deactivate and discard draft buttons to the backend.
Made it possible to "edit" active and deactivated versions by automatically creating a new draft version when the user tries to edit the version.
Hide the "Discard Draft", button if the current version is not a draft or is the first version ever created.
On the backend, don't consider discarded drafts when checking if a new draft version can be created.
On the backend, disallow deleting the first created workflow version. Otherwise, we will end up with a blank canvas in the front end, and it will be impossible to recover from it.
On the backend, disallow running deactivation steps if the workflow version is not currently active. Previously, we were throwing, which is unnecessary as it's a valid case.

Spotted bugs that we must dive into

Duplicate workflow versions in Apollo cache

CleanShot.2024-09-20.at.12.18.49.mp4

packages/twenty-front/src/modules/workflow/hooks/useWorkflowWithCurrentVersion.tsx

Devessier · 2024-09-20T10:54:27Z

.../modules/workflow/common/workspace-services/workflow-version-validation.workspace-service.ts

@@ -48,6 +50,8 @@ export class WorkflowVersionValidationWorkspaceService {
        where: {
          workflowId: payload.data.workflowId,
          status: WorkflowVersionStatus.DRAFT,
+          // FIXME: soft-deleted rows selection will have to be improved globally
+          deletedAt: IsNull(),


Discarded drafts (soft deleted) were corrupting this check.

...c/modules/workflow/workflow-trigger/workspace-services/workflow-trigger.workspace-service.ts

packages/twenty-front/src/modules/workflow/hooks/useCreateStep.tsx

packages/twenty-front/src/modules/workflow/components/RecordShowPageHeaderWorkflow.tsx

packages/twenty-front/src/pages/object-record/RecordShowPage.tsx

...c/modules/workflow/workflow-trigger/workspace-services/workflow-trigger.workspace-service.ts

packages/twenty-front/src/modules/workflow/hooks/useWorkflowWithCurrentVersion.tsx

packages/twenty-front/src/modules/workflow/hooks/useCreateStep.tsx

...c/modules/workflow/workflow-trigger/workspace-services/workflow-trigger.workspace-service.ts

…tation

…sion

…rsion (no version prior to this one)

This reverts commit d40f90d.

…rkflow versions

…e component and rename workflow actions

…the next version

github-actions · 2024-09-25T16:10:36Z

Thanks @Devessier for your contribution!
This marks your 7th PR on the repo. You're top 4% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Devessier mentioned this pull request Sep 16, 2024

Finish workflow version activation/deactivation & discard draft #7060

Closed

Devessier force-pushed the activate-deactivate-workflow branch 2 times, most recently from 980f09b to df8f2bf Compare September 20, 2024 09:40

Devessier commented Sep 20, 2024

View reviewed changes

packages/twenty-front/src/modules/workflow/hooks/useWorkflowWithCurrentVersion.tsx Outdated Show resolved Hide resolved

Devessier commented Sep 20, 2024

View reviewed changes

...c/modules/workflow/workflow-trigger/workspace-services/workflow-trigger.workspace-service.ts Show resolved Hide resolved

Devessier marked this pull request as ready for review September 20, 2024 11:18

This comment was marked as outdated.

Sign in to view

thomtrp reviewed Sep 20, 2024

View reviewed changes

thomtrp reviewed Sep 23, 2024

View reviewed changes

packages/twenty-front/src/modules/workflow/hooks/useCreateStep.tsx Outdated Show resolved Hide resolved

...c/modules/workflow/workflow-trigger/workspace-services/workflow-trigger.workspace-service.ts Show resolved Hide resolved

Devessier force-pushed the activate-deactivate-workflow branch from 13ab33f to a5270fa Compare September 24, 2024 08:34

Devessier added 19 commits September 25, 2024 10:22

feat: allow activating workflow version and refetch its data after mu…

2bff5cb

…tation

feat: add buttons related to workflows in record show header

cfe15a9

feat: allow deactivating workflow

682f3f5

feat: create new workflow version when trying to edit a not draft ver…

1d166dc

…sion

feat: allow discard current workflow draft version

aba4bdc

refactor: specialize the hook that deletes a workflow version

f352023

fix: prevent JSON value from being serialized twice

3b8bedf

fix: prevent soft-deleted draft versions to leak

de9f5eb

feat: allow to discard a draft only if it's not the first workflow ve…

6d7e656

…rsion (no version prior to this one)

feat: prevent the deletion of the initial version of a workflow

58dff55

fix: don't try to deactivate deactivated and archived versions

0c1cc04

Revert "fix: prevent JSON value from being serialized twice"

bc9f761

This reverts commit d40f90d.

test: write tests for the RecordShowPageHearderWorkflow component

0c8275a

test: update msw service worker script

cb64d98

test: found the correct place to put metadata response

5abfebf

test: disable global msw mocks for workflows

24da378

test: change how we set up msw handlers

c2a6067

test: find a way to properly override global msw mocks

827d34c

test: associate a different workflow id to each story

a4237c6

Devessier added 6 commits September 25, 2024 10:32

feat: don't fetch all versions data when we only need the count of wo…

883e635

…rkflow versions

refactor: extract common record show page header actions in a separat…

e928b12

…e component and rename workflow actions

refactor: use the number of workflow versions to compute the name of …

eecb639

…the next version

revert: delete the updated mock of the /metadata response

0bf8046

build: improve seed script by creating custom objects

2f09924

feat: update mocked data

f21a854

Devessier force-pushed the activate-deactivate-workflow branch from 8abdda6 to f21a854 Compare September 25, 2024 10:51

charlesBochet and others added 9 commits September 25, 2024 15:23

Deperecate getObjectMetadataItemsMock

df71b0e

Fix tests 1

29d0dc4

Fix tests

c59ae77

test: regenerate metadata mock file

fe542ee

Fix tests

631ab78

Fix tests

b40c560

Fix tests

73efe7d

Fix tests

8fb9da0

Fix tests

5018155

charlesBochet force-pushed the activate-deactivate-workflow branch from 59361ab to 5018155 Compare September 25, 2024 15:28

charlesBochet added 2 commits September 25, 2024 17:35

Fix lint

c51cc86

Increase test coverage

52b7f85

charlesBochet merged commit 729c990 into main Sep 25, 2024
9 of 13 checks passed

charlesBochet deleted the activate-deactivate-workflow branch September 25, 2024 16:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Activate/Deactivate workflow and Discard Draft #7022

Activate/Deactivate workflow and Discard Draft #7022

Devessier commented Sep 13, 2024 •

edited

Loading

Devessier Sep 20, 2024

This comment was marked as outdated.

github-actions bot commented Sep 25, 2024

Activate/Deactivate workflow and Discard Draft #7022

Activate/Deactivate workflow and Discard Draft #7022

Conversation

Devessier commented Sep 13, 2024 • edited Loading

Setup

What this PR brings

Spotted bugs that we must dive into

Duplicate workflow versions in Apollo cache

Devessier Sep 20, 2024

Choose a reason for hiding this comment

This comment was marked as outdated.

github-actions bot commented Sep 25, 2024

Devessier commented Sep 13, 2024 •

edited

Loading