Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduced Specific Icons image identifier for Notes and Tasks #6997

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Introduced Specific Icons image identifier for Notes and Tasks #6997

wants to merge 6 commits into from
+87 −11

Conversation

ehconitin
Copy link
Contributor

@ehconitin ehconitin commented Sep 11, 2024 •
edited by lucasbordeau
Loading

Fixes #6486

@ehconitin ehconitin marked this pull request as ready for review September 12, 2024 04:50
greptile-apps[bot]
greptile-apps bot reviewed Sep 12, 2024
View reviewed changes
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR introduces specific icons for Notes and Tasks, improving visual differentiation in the UI. Key changes include:

  • Added getAvatarIcon.ts utility to determine appropriate icons and colors for different object types
  • Updated RecordIndexRecordChip and RecordShowContainer to use new icons for Notes and Tasks
  • Modified ShowPageSummaryCard and Avatar components to support custom icons and colors
  • Added 'icon' option to AvatarType and introduced LeftIconColor prop in AvatarChip
  • Introduced new color constants 'yellowIcon' and 'blueIcon' in SecondaryColors.ts

These changes align with the desired behavior described in issue #6486, enhancing the visual distinction between Notes, Tasks, and other object types.

8 file(s) reviewed, 9 comment(s)
Edit PR Review Bot Settings

packages/twenty-front/src/modules/object-metadata/utils/getAvatarIcon.ts Outdated Show resolved Hide resolved
packages/twenty-front/src/modules/object-metadata/utils/getAvatarIcon.ts Outdated Show resolved Hide resolved
packages/twenty-front/src/modules/object-record/record-show/components/RecordShowContainer.tsx Show resolved Hide resolved
packages/twenty-front/src/modules/object-record/record-show/components/RecordShowContainer.tsx Show resolved Hide resolved
packages/twenty-front/src/modules/ui/layout/show-page/components/ShowPageSummaryCard.tsx Show resolved Hide resolved
packages/twenty-front/src/modules/ui/layout/show-page/components/ShowPageSummaryCard.tsx Outdated Show resolved Hide resolved
packages/twenty-ui/src/display/chip/components/AvatarChip.tsx Outdated Show resolved Hide resolved
packages/twenty-ui/src/display/chip/components/AvatarChip.tsx Outdated Show resolved Hide resolved
@ehconitin ehconitin mentioned this pull request Sep 12, 2024
Open
@lucasbordeau lucasbordeau self-assigned this Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bonapara Bonapara Bonapara left review comments

@greptile-apps Greptile Apps greptile-apps left review comments

@lucasbordeau lucasbordeau Awaiting requested review from lucasbordeau

At least 1 approving review is required to merge this pull request.

Assignees

@lucasbordeau lucasbordeau

Labels
-PR: awaiting author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce Specific Icons image identifier for Notes and Tasks
4 participants
@ehconitin @Bonapara @lucasbordeau @charlesBochet