Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to filter by composite's subfields #6832

Merged

Conversation

pacyL2K19
Copy link
Contributor

@pacyL2K19 pacyL2K19 commented Sep 2, 2024

This PR

See #7188 because there's some more work to do.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request is a work in progress (WIP) that aims to update the UI to allow filtering by composite sub-fields, addressing issue #6445 related to Objects/Fields improvements.

  • Implements filtering functionality for composite sub-fields in the UI
  • Addresses a specific aspect of the larger Objects/Fields Master Issue (Objects/Fields Master Issue #6445)
  • Part of the "Fields Filtering / Sorting" category in the master issue tasklist
  • No specific file changes are provided in the current state of the PR

No file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@pacyL2K19 pacyL2K19 changed the title [WIP] feat(UI): update the UI to allow filtering by composite sub-fields Ability to filter by composite's subfields Sep 2, 2024
@pacyL2K19
Copy link
Contributor Author

@charlesBochet @Bonapara
This is ready for review, looking forward for getting your feedback

Copy link
Contributor

@martmull martmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey nice work thank you. Some comments though

Behaviour:
Think we can add a "go back" arrow when selecting the subField in the filter dropdown
image

The rest seems to work well!

@pacyL2K19
Copy link
Contributor Author

Thank you for the reviews @martmull
Working on them today

@pacyL2K19
Copy link
Contributor Author

Hey nice work thank you. Some comments though

Behaviour: Think we can add a "go back" arrow when selecting the subField in the filter dropdown image

The rest seems to work well!

Do we have any figma design for this ui/ux @martmull ?

@martmull
Copy link
Contributor

@pacyL2K19, @Bonapara is updating the figma. We think this go back arrow will be required in all fields, not only subfields. So it deserves its own ticket. Lets not pass the changes in that PR, you can resolve this comment, thanks

@lucasbordeau lucasbordeau merged commit 4156d78 into twentyhq:main Oct 8, 2024
14 checks passed
Copy link

github-actions bot commented Oct 8, 2024

Thanks @pacyL2K19 for your contribution!
This marks your 10th PR on the repo. You're top 3% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Contributions

harshit078 pushed a commit to harshit078/twenty that referenced this pull request Oct 14, 2024
# This PR

- Fix twentyhq#6425 

See twentyhq#7188 because there's some
more work to do.

---------

Co-authored-by: Lucas Bordeau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Filtering by Sub-fields in Composite Fields
5 participants