PG16 got stricter about Datum vs. Pointer #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thanodnl
reviewed
Sep 22, 2023
| @@ -2659,7 +2659,6 @@ tdigest_in(PG_FUNCTION_ARGS) | |||
| /* the centroids should be sorted by mean */ | |||
| if (i > 0) | |||
| { | |||
| double mean = digest->centroids[i].mean; | |||
There was a problem hiding this comment.
The declaration of mean on line 2662 shadowed the declaration from line 2642. Coincidentally at line 2648 we store mean in digest->centroids[i].mean so there is also no reason to read mean here again.
Not redeclaring mean here has a slight side effect where in certain situations the original mean has a different value after this branch. However, mean is not read anymore, and redeclared and initialized in the next iteration of the loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #25.