Alora Riley #2
Open
Alora Riley #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicktu12
reviewed
Sep 13, 2024
| @candidates = [] | ||
| end | ||
|
|
||
| def register_candidate!(candidate_info) |
There was a problem hiding this comment.
What is the ! operator doing here?
nicktu12
reviewed
Sep 13, 2024
| end | ||
|
|
||
| describe '#votes' do | ||
| it 'has zero votes by default' do |
There was a problem hiding this comment.
Nice test to check the initial state of things
nicktu12
reviewed
Sep 13, 2024
| return @races | ||
| end | ||
|
|
||
| def add_candidate_to_election(candidate_info) |
There was a problem hiding this comment.
This method appears to be doing almost the same thing as register candidate - do you need both?
nicktu12
reviewed
Sep 13, 2024
| end | ||
|
|
||
| def candiate_name(candidates) | ||
| candidates.map do |candiate| |
There was a problem hiding this comment.
If my map or enum is simple like this - I really like to use the shorter syntax!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we worked on the battleship project all week, I got to this IC and I felt like I was typing so slowly through it. I didn't finish the last two methods of iteration 3. The reaching through objects and creating a hash with them felt challenging.