Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CHANGELOG for v1.2.0 #682

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Add CHANGELOG for v1.2.0 #682

merged 2 commits into from
Nov 5, 2024

Conversation

khushboo9024
Copy link
Contributor

Integration test logs

Logs
Add passing integration test logs here

Example query results

Results
Add example SQL query results here (please include the input queries as well)

@khushboo9024 khushboo9024 self-assigned this Nov 4, 2024
Copy link
Contributor

@misraved misraved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at the review comments. Thanks!!

CHANGELOG.md Outdated

_Bug fixes_

- Fixed the `gcp_compute_instance_group` table to correctly return values for the `instances` column in cases of regional instance groups. ([#670](https://github.com/turbot/steampipe-plugin-gcp/pull/670)) (Thanks [@pdecat](https://github.com/pdecat) for the contribution!)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Fixed the `gcp_compute_instance_group` table to correctly return values for the `instances` column in cases of regional instance groups. ([#670](https://github.com/turbot/steampipe-plugin-gcp/pull/670)) (Thanks [@pdecat](https://github.com/pdecat) for the contribution!)
- Fixed the `gcp_compute_instance_group` table to correctly return values for the `instances` column of regional instance groups. ([#670](https://github.com/turbot/steampipe-plugin-gcp/pull/670)) (Thanks [@pdecat](https://github.com/pdecat) for the contribution!)

CHANGELOG.md Outdated
_Bug fixes_

- Fixed the `gcp_compute_instance_group` table to correctly return values for the `instances` column in cases of regional instance groups. ([#670](https://github.com/turbot/steampipe-plugin-gcp/pull/670)) (Thanks [@pdecat](https://github.com/pdecat) for the contribution!)
- Fixed the `kubernetes_node_pool` table to correctly return values when `cluster.Autopilot` is `nil`. ([#668](https://github.com/turbot/steampipe-plugin-gcp/pull/668)) (Thanks [@multani](https://github.com/multani) for the contribution!)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Fixed the `kubernetes_node_pool` table to correctly return values when `cluster.Autopilot` is `nil`. ([#668](https://github.com/turbot/steampipe-plugin-gcp/pull/668)) (Thanks [@multani](https://github.com/multani) for the contribution!)
- Fixed the `kubernetes_node_pool` table to correctly return data instead of an error for node pools with auto-pilot disabled. ([#668](https://github.com/turbot/steampipe-plugin-gcp/pull/668)) (Thanks [@multani](https://github.com/multani) for the contribution!)

@misraved misraved merged commit a32f3fb into main Nov 5, 2024
1 check passed
@misraved misraved deleted the release/v1.2.0 branch November 5, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants