-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a student id check #24
base: master
Are you sure you want to change the base?
Conversation
src/main/kotlin/org/tudalgo/algomate/extension/SubmissionExtension.kt
Outdated
Show resolved
Hide resolved
Hmm could we not go for a more exact regex, like |
The initial point of this was to simply ensure that no matriculation numbers are entered. I'm not opposed to updating it, but is there a guarantee that all TU-IDs have this format? |
A more specific regex would be incorrect. I have seen valid TU-IDs with only one letter (some old ones). The only commonality I have found is that they all have at least one letter, and this simple check is enough to prevent using the matriculation number instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I would still like to test it first before merging
This pr aims to add a method to the build tasks that tries to catch students who enter their matriculation number in the
studentId
field, fail the build and inform them about their mistake.