hrpc, region: Allow setting priority on Scan and Get requests #267
Conversation
Provide an option for setting the priority on a Scan or Get request. The priority is set on the RequestHeader, so must be set by the region code when serializing the request.
| func (bq *baseQuery) setPriority(priority uint32) { | ||
| bq.priority = priority | ||
| } | ||
| func (bq *baseQuery) Priority() *uint32 { |
There was a problem hiding this comment.
Returning by point here is weird. I understand that when we marshal to proto it wants pointers-to-int and maybe doing it this way avoids an allocation (because otherwise in marshalProto() you'd have to create an int and take its address thereby causing a heap allocation of a new integer), but from an API perspective it's odd. Did you do it this way to avoid an allocation?
There was a problem hiding this comment.
Yeah, to avoid an allocation.
There was a problem hiding this comment.
And now this has become slightly awkward in #268, which fixes something I missed here.
There was a problem hiding this comment.
Oh I didn't notice that. I think returning just uint32 make more sense. Returning a pointer or a uint32 is the same in the end
There was a problem hiding this comment.
It's same except for the added allocation. The extra allocation is not a big deal, so I'll just clean this up in #268.
Provide an option for setting the priority on a Scan or Get request. The priority is set on the RequestHeader, so must be set by the region code when serializing the request.