Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SendBatch API #202

Merged
merged 4 commits into from
Jul 27, 2023
Merged

Add SendBatch API #202

merged 4 commits into from
Jul 27, 2023

Commits on Jul 20, 2023

  1. Implement SendBatch

    @aaronbee
    aaronbee committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    c5b5b5f View commit details
    Browse the repository at this point in the history

  2. region: Make rpcs chan []hrpc.Call 

    Change the rpcs chan from holding hrpc.Call to []hrpc.Call. This is
required for batch support.
    @aaronbee
    aaronbee committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    4c81866 View commit details
    Browse the repository at this point in the history

  3. region: Implement QueueBatch 

    Allows passing a batch of RPCs to the region client, which will be
added to the in progress multi and then sent to HBASE.

A note here is that it's possible for a multi to grow beyond the size
of the configured size. This feels like the right way to go because
the user of the Batch API has specifically requested the rpcs be
batched together, so splitting the batch across multiple multi's
breaks that bit of atomicity.
    @aaronbee
    aaronbee committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    b886475 View commit details
    Browse the repository at this point in the history

  4. hrpc: Add QueueBatch to the RegionClient interface 

    Removes a type assert in SendBatch.
    @aaronbee
    aaronbee committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    023669f View commit details
    Browse the repository at this point in the history