region: add a metric to track bytes written to the wire per RPC call

tsuna · Jun 10, 2024 · 1fee39f · 1fee39f
1 parent 67d205c
commit 1fee39f
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 3 deletions.
diff --git a/region/client.go b/region/client.go
@@ -658,6 +658,7 @@ func (c *client) send(rpc hrpc.Call) (uint32, error) {
 		return id, err
 	}
 
+	rpcSize.WithLabelValues(c.Addr()).Observe(float64(uint32(len(b)) + cellblocksLen))
 	if cellblocks != nil {
 		bfs := append(net.Buffers{b}, cellblocks...)
 		_, err = bfs.WriteTo(c.conn)

diff --git a/region/compressor.go b/region/compressor.go
@@ -38,9 +38,9 @@ func resizeBufferCap(b []byte, capacity int) []byte {
 		return b
 	}
 
-	l := len(b)
-	b = append(b, make([]byte, capacity-l)...)
-	return b[:l]
+	b2 := make([]byte, capacity)
+	copy(b2, b)
+	return b2[:len(b)]
 }
 
 func (c *compressor) compressCellblocks(cbs net.Buffers, uncompressedLen uint32) []byte {

diff --git a/region/prometheus.go b/region/prometheus.go
@@ -29,4 +29,16 @@ var (
 		},
 		[]string{"regionserver"},
 	)
+
+	rpcSize = promauto.NewHistogramVec(
+		prometheus.HistogramOpts{
+			Namespace: "gohbase",
+			Name:      "rpc_size_bytes",
+			Help:      "Number of bytes sent per RPC call to HBase",
+			// >>> [1024*(4**i) for i in range(8)]
+			// [1024, 4096, 16384, 65536, 262144, 1048576, 4194304, 16777216]
+			Buckets: prometheus.ExponentialBuckets(1024, 4, 8),
+		},
+		[]string{"regionserver"},
+	)
 )