Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick worker with established connection #99

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

sevenhe1205
Copy link

Pick a subchannel which connection is established

  • When a grpcbox_channel adds a grpcbox_subchannel, the grpcbox_subchannel will try to establish an HTTP/2 connection.
  • If the HTTP/2 connection is successfully established, the grpcbox_subchannel will add itself to the {channel, active} pool. If the HTTP/2 connection is not successfully established, the grpcbox_subchannel will retry establishing the connection at a specified interval.
  • The grpcbox_subchannel will check the HTTP/2 connection status by itself, and if it detects a disconnection, it will remove itself from the {channel, active} pool.
  • When an application needs to choose a connected grpcbox_subchannel with an established HTTP/2 connection, it can select an available grpcbox_subchannel from the {channel, active} pool.
  • When a grpcbox_subchannel is no longer needed, it should be removed from the {channel, active} pool.

@gilbertwong96
Copy link

Please provide a clearer description by answering the following questions:

  1. What specific problem did you encounter?
  2. Why do you want to introduce this feature?
  3. How do you plan to implement it?

@tsloughter
Copy link
Owner

Thanks! I like the idea. It'll take me a bit to get around to a thorough review.

Curious, did you hit this as an issue in your usage?

@sevenhe1205 sevenhe1205 force-pushed the pick-worker-with-established-connection branch from ba8256d to 9012472 Compare April 14, 2023 04:15
@sevenhe1205 sevenhe1205 force-pushed the pick-worker-with-established-connection branch from 9012472 to 96c4696 Compare May 4, 2023 15:51
@sevenhe1205 sevenhe1205 force-pushed the pick-worker-with-established-connection branch from 96c4696 to 3122d30 Compare June 5, 2023 02:14
@sevenhe1205 sevenhe1205 force-pushed the pick-worker-with-established-connection branch from 3122d30 to 48f2609 Compare June 5, 2023 02:58
@tsloughter
Copy link
Owner

@sevenhe1205 Can you rebase these changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants