Skip to content

Commit

Permalink
fix: Rename legacy line and area charts (apache#28113)
Browse files Browse the repository at this point in the history
  • Loading branch information
john-bodley authored and michael-s-molina committed May 3, 2024
1 parent 552474a commit 1ff2c3b
Show file tree
Hide file tree
Showing 33 changed files with 40 additions and 2,379 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ describe('Charts filters', () => {
});

it('should allow filtering by "Type" correctly', () => {
setFilter('Type', 'Area Chart (legacy)');
setFilter('Type', 'Area Chart');
setFilter('Type', 'Bubble Chart');
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ const metadata = new ChartMetadata({
{ url: example4, caption: t('Vehicle Types') },
],
label: ChartLabel.Deprecated,
name: t('Area Chart (legacy)'),
name: t('Time-series Area Chart (legacy)'),
supportedAnnotationTypes: [ANNOTATION_TYPES.INTERVAL, ANNOTATION_TYPES.EVENT],
tags: [
t('Aesthetic'),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ const metadata = new ChartMetadata({
{ url: battery, caption: t('Battery level over time') },
],
label: ChartLabel.Deprecated,
name: t('Line Chart (legacy)'),
name: t('Time-series Line Chart (legacy)'),
supportedAnnotationTypes: [
ANNOTATION_TYPES.TIME_SERIES,
ANNOTATION_TYPES.INTERVAL,
Expand Down
4 changes: 2 additions & 2 deletions superset/translations/de/LC_MESSAGES/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -775,7 +775,7 @@
"Möchten Sie die Änderungen wirklich speichern und anwenden?"
],
"Area Chart": ["Flächendiagramm"],
"Area Chart (legacy)": ["Flächendiagramm (Legacy)"],
"Time-series Area Chart (legacy)": ["Flächendiagramm (Legacy)"],
"Area chart": ["Flächendiagramm"],
"Area chart opacity": ["Deckkraft des Flächendiagramms"],
"Area charts are similar to line charts in that they represent variables with the same scale, but area charts stack the metrics on top of each other.": [
Expand Down Expand Up @@ -2684,7 +2684,7 @@
],
"Line": ["Linie"],
"Line Chart": ["Liniendiagramm"],
"Line Chart (legacy)": ["Liniendiagramm (Legacy)"],
"Time-series Line Chart (legacy)": ["Liniendiagramm (Legacy)"],
"Line Style": ["Linien Stil"],
"Line chart is used to visualize measurements taken over a given category. Line chart is a type of chart which displays information as a series of data points connected by straight line segments. It is a basic type of chart common in many fields.": [
"Liniendiagramm wird verwendet, um Messungen zu visualisieren, die über eine bestimmte Kategorie durchgeführt wurden. Liniendiagramm ist eine Art Diagramm, das Informationen als eine Reihe von Datenpunkten anzeigt, die durch gerade Liniensegmente verbunden sind. Es ist ein grundlegender Diagrammtyp, der in vielen Bereichen üblich ist."
Expand Down
2 changes: 1 addition & 1 deletion superset/translations/de/LC_MESSAGES/messages.po
Original file line number Diff line number Diff line change
Expand Up @@ -2461,7 +2461,7 @@ msgid "Area Chart"
msgstr "Flächendiagramm"

#: superset-frontend/plugins/legacy-preset-chart-nvd3/src/Area/index.js:42
msgid "Area Chart (legacy)"
msgid "Time-series Area Chart (legacy)"
msgstr "Flächendiagramm (Legacy)"

#: superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx:177
Expand Down
4 changes: 2 additions & 2 deletions superset/translations/en/LC_MESSAGES/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -534,7 +534,7 @@
"Are you sure you want to proceed?": [""],
"Are you sure you want to save and apply changes?": [""],
"Area Chart": [""],
"Area Chart (legacy)": [""],
"Time-series Area Chart (legacy)": [""],
"Area chart": [""],
"Area chart opacity": [""],
"Area charts are similar to line charts in that they represent variables with the same scale, but area charts stack the metrics on top of each other.": [
Expand Down Expand Up @@ -2043,7 +2043,7 @@
],
"Line": [""],
"Line Chart": [""],
"Line Chart (legacy)": [""],
"Time-series Line Chart (legacy)": [""],
"Line Style": [""],
"Line chart is used to visualize measurements taken over a given category. Line chart is a type of chart which displays information as a series of data points connected by straight line segments. It is a basic type of chart common in many fields.": [
""
Expand Down
2 changes: 1 addition & 1 deletion superset/translations/en/LC_MESSAGES/messages.po
Original file line number Diff line number Diff line change
Expand Up @@ -2284,7 +2284,7 @@ msgid "Area Chart"
msgstr ""

#: superset-frontend/plugins/legacy-preset-chart-nvd3/src/Area/index.js:42
msgid "Area Chart (legacy)"
msgid "Time-series Area Chart (legacy)"
msgstr ""

#: superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx:177
Expand Down
2 changes: 1 addition & 1 deletion superset/translations/es/LC_MESSAGES/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -1707,7 +1707,7 @@
"Limits the number of the rows that are computed in the query that is the source of the data used for this chart.": [
""
],
"Line Chart (legacy)": [""],
"Time-series Line Chart (legacy)": [""],
"Line Style": [""],
"Line interpolation as defined by d3.js": [""],
"Line width": ["Grosor de línea"],
Expand Down
2 changes: 1 addition & 1 deletion superset/translations/es/LC_MESSAGES/messages.po
Original file line number Diff line number Diff line change
Expand Up @@ -2436,7 +2436,7 @@ msgstr "Compartir gráfico"

#: superset-frontend/plugins/legacy-preset-chart-nvd3/src/Area/index.js:42
#, fuzzy
msgid "Area Chart (legacy)"
msgid "Time-series Area Chart (legacy)"
msgstr "Compartir gráfico"

#: superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx:177
Expand Down
2 changes: 1 addition & 1 deletion superset/translations/fr/LC_MESSAGES/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -2189,7 +2189,7 @@
"Limits the number of the rows that are computed in the query that is the source of the data used for this chart.": [
"Définissez une fonction javascript qui reçoit le tableau de données utilisé dans la visualisation et qui doit renvoyer une version modifiée de ce tableau. Cette fonction peut être utilisée pour modifier les propriétés des données, filtrer ou enrichir le tableau."
],
"Line Chart (legacy)": ["Tableau linéaire (héritage)"],
"Time-series Line Chart (legacy)": ["Tableau linéaire (héritage)"],
"Line Style": ["Style de ligne"],
"Line chart is used to visualize measurements taken over a given category. Line chart is a type of chart which displays information as a series of data points connected by straight line segments. It is a basic type of chart common in many fields.": [
"Le graphique linéaire est utilisé pour visualiser les mesures prises sur une catégorie donnée. Le graphique linéaire est un type de graphique qui affiche les informations sous forme de série de points de données reliés par des segments linéaires. Il s’agit d’un type de tableau de base commun dans de nombreux champs."
Expand Down
2 changes: 1 addition & 1 deletion superset/translations/fr/LC_MESSAGES/messages.po
Original file line number Diff line number Diff line change
Expand Up @@ -2393,7 +2393,7 @@ msgstr "Graphique en aires"

#: superset-frontend/plugins/legacy-preset-chart-nvd3/src/Area/index.js:42
#, fuzzy
msgid "Area Chart (legacy)"
msgid "Time-series Area Chart (legacy)"
msgstr "Graphique en aires (hérité)"

#: superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx:177
Expand Down
2 changes: 1 addition & 1 deletion superset/translations/it/LC_MESSAGES/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -1687,7 +1687,7 @@
"Limits the number of the rows that are computed in the query that is the source of the data used for this chart.": [
""
],
"Line Chart (legacy)": [""],
"Time-series Line Chart (legacy)": [""],
"Line Style": [""],
"Line chart is used to visualize measurements taken over a given category. Line chart is a type of chart which displays information as a series of data points connected by straight line segments. It is a basic type of chart common in many fields.": [
""
Expand Down
2 changes: 1 addition & 1 deletion superset/translations/it/LC_MESSAGES/messages.po
Original file line number Diff line number Diff line change
Expand Up @@ -2378,7 +2378,7 @@ msgstr "Esplora grafico"

#: superset-frontend/plugins/legacy-preset-chart-nvd3/src/Area/index.js:42
#, fuzzy
msgid "Area Chart (legacy)"
msgid "Time-series Area Chart (legacy)"
msgstr "Esplora grafico"

#: superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx:177
Expand Down
2 changes: 1 addition & 1 deletion superset/translations/ja/LC_MESSAGES/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -1719,7 +1719,7 @@
"Limits the number of the rows that are computed in the query that is the source of the data used for this chart.": [
""
],
"Line Chart (legacy)": [""],
"Time-series Line Chart (legacy)": [""],
"Line Style": [""],
"Line chart is used to visualize measurements taken over a given category. Line chart is a type of chart which displays information as a series of data points connected by straight line segments. It is a basic type of chart common in many fields.": [
""
Expand Down
2 changes: 1 addition & 1 deletion superset/translations/ja/LC_MESSAGES/messages.po
Original file line number Diff line number Diff line change
Expand Up @@ -2379,7 +2379,7 @@ msgstr "チャートを保存"

#: superset-frontend/plugins/legacy-preset-chart-nvd3/src/Area/index.js:42
#, fuzzy
msgid "Area Chart (legacy)"
msgid "Time-series Area Chart (legacy)"
msgstr "チャートを保存"

#: superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx:177
Expand Down
2 changes: 1 addition & 1 deletion superset/translations/ko/LC_MESSAGES/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -1729,7 +1729,7 @@
"Limits the number of the rows that are computed in the query that is the source of the data used for this chart.": [
""
],
"Line Chart (legacy)": [""],
"Time-series Line Chart (legacy)": [""],
"Line Style": [""],
"Line chart is used to visualize measurements taken over a given category. Line chart is a type of chart which displays information as a series of data points connected by straight line segments. It is a basic type of chart common in many fields.": [
""
Expand Down
2 changes: 1 addition & 1 deletion superset/translations/ko/LC_MESSAGES/messages.po
Original file line number Diff line number Diff line change
Expand Up @@ -2364,7 +2364,7 @@ msgstr "차트 보기"

#: superset-frontend/plugins/legacy-preset-chart-nvd3/src/Area/index.js:42
#, fuzzy
msgid "Area Chart (legacy)"
msgid "Time-series Area Chart (legacy)"
msgstr "차트 보기"

#: superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx:177
Expand Down
4 changes: 2 additions & 2 deletions superset/translations/nl/LC_MESSAGES/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -582,7 +582,7 @@
"Weet u zeker dat u de wijzigingen wilt opslaan en toepassen?"
],
"Area Chart": [""],
"Area Chart (legacy)": [""],
"Time-series Area Chart (legacy)": [""],
"Area chart": [""],
"Area chart opacity": [""],
"Area charts are similar to line charts in that they represent variables with the same scale, but area charts stack the metrics on top of each other.": [
Expand Down Expand Up @@ -2100,7 +2100,7 @@
],
"Line": [""],
"Line Chart": [""],
"Line Chart (legacy)": [""],
"Time-series Line Chart (legacy)": [""],
"Line Style": [""],
"Line chart is used to visualize measurements taken over a given category. Line chart is a type of chart which displays information as a series of data points connected by straight line segments. It is a basic type of chart common in many fields.": [
""
Expand Down
2 changes: 1 addition & 1 deletion superset/translations/nl/LC_MESSAGES/messages.po
Original file line number Diff line number Diff line change
Expand Up @@ -2407,7 +2407,7 @@ msgid "Area Chart"
msgstr ""

#: superset-frontend/plugins/legacy-preset-chart-nvd3/src/Area/index.js:42
msgid "Area Chart (legacy)"
msgid "Time-series Area Chart (legacy)"
msgstr ""

#: superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx:177
Expand Down
Loading

0 comments on commit 1ff2c3b

Please sign in to comment.