Fixing failing doctests, revert hiding _one_* method.

tscrim · Aug 19, 2023 · be1d7c3 · be1d7c3
1 parent 5a0232b
commit be1d7c3
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 11 deletions.
diff --git a/src/sage/categories/algebras.py b/src/sage/categories/algebras.py
@@ -215,9 +215,8 @@ def extra_super_categories(self):
                 sage: C.extra_super_categories()
                 [Category of algebras over Rational Field]
                 sage: sorted(C.super_categories(), key=str)
-                [Category of Cartesian products of distributive magmas and additive magmas,
-                 Category of Cartesian products of monoids,
-                 Category of Cartesian products of vector spaces over Rational Field,
+                [Category of Cartesian products of monoids,
+                 Category of Cartesian products of unital algebras over Rational Field,
                  Category of algebras over Rational Field]
             """
             return [self.base_category()]

diff --git a/src/sage/categories/algebras_with_basis.py b/src/sage/categories/algebras_with_basis.py
@@ -228,7 +228,7 @@ def extra_super_categories(self):
 
         class ParentMethods:
             @cached_method
-            def _one_from_cartesian_product_of_one_basis(self):
+            def one_from_cartesian_product_of_one_basis(self):
                 """
                 Return the one of this Cartesian product of algebras, as per
                 ``Monoids.ParentMethods.one``
@@ -249,7 +249,7 @@ def _one_from_cartesian_product_of_one_basis(self):
                     word:
 
                     sage: B = cartesian_product((A, A, A))                              # optional - sage.combinat
-                    sage: B.one_from_cartesian_product_of_one_basis()                   # optional - sage.combinat
+                    sage: B.one_from_cartesian_product_of_one_basis()                  # optional - sage.combinat
                     B[(0, word: )] + B[(1, word: )] + B[(2, word: )]
                     sage: B.one()                                                       # optional - sage.combinat
                     B[(0, word: )] + B[(1, word: )] + B[(2, word: )]
@@ -273,7 +273,7 @@ def one(self):
                     B[(0, word: )] + B[(1, word: )] + B[(2, word: )]
                 """
                 if all(hasattr(module, "one_basis") and module.one_basis is not NotImplemented for module in self._sets):
-                    return self._one_from_cartesian_product_of_one_basis
+                    return self.one_from_cartesian_product_of_one_basis
                 return self._one_generic
 
             _one_generic = UnitalAlgebras.CartesianProducts.ParentMethods.one

diff --git a/src/sage/categories/unital_algebras.py b/src/sage/categories/unital_algebras.py
@@ -400,12 +400,12 @@ def extra_super_categories(self):
                 sage: from sage.categories.unital_algebras import UnitalAlgebras
                 sage: C = UnitalAlgebras(QQ).CartesianProducts()
                 sage: C.extra_super_categories()
-                [Category of algebras over Rational Field]
+                [Category of unital algebras over Rational Field]
                 sage: sorted(C.super_categories(), key=str)
                 [Category of Cartesian products of distributive magmas and additive magmas,
-                 Category of Cartesian products of monoids,
+                 Category of Cartesian products of unital magmas,
                  Category of Cartesian products of vector spaces over Rational Field,
-                 Category of algebras over Rational Field]
+                 Category of unital algebras over Rational Field]
             """
             return [self.base_category()]
 
@@ -428,5 +428,5 @@ def one(self):
                     sage: all(b == b * one for b in C.basis())
                     True
                 """
-                return self.sum(self.cartesian_embedding(i)(C.one())
-                                for i, C in enumerate(self.cartesian_factors()))
+                data = enumerate(self.cartesian_factors())
+                return self._cartesian_product_of_elements([C.one() for i, C in data])