Skip to content

Commit

Permalink
Addressing reviewer comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
tscrim committed Nov 23, 2023
1 parent 44b42b8 commit 721b952
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 4 deletions.
4 changes: 2 additions & 2 deletions src/sage/combinat/partition.py
Original file line number Diff line number Diff line change
Expand Up @@ -5538,8 +5538,8 @@ def simple_module_dimension(self, base_ring=None):
r"""
Return the dimension of the simple module corresponding to ``self``.
This is equal to the dimension of the Specht module over a field
of characteristic `0`.
When the base ring is a field of characteristic `0`, this is equal
to the dimension of the Specht module.
INPUT:
Expand Down
18 changes: 16 additions & 2 deletions src/sage/combinat/specht_module.py
Original file line number Diff line number Diff line change
Expand Up @@ -475,7 +475,7 @@ def polytabloid(T):
OUTPUT:
A ``dict`` whose keys are taboids represented by tuples of frozensets
A ``dict`` whose keys are tabloids represented by tuples of frozensets
and whose values are the coefficient.
EXAMPLES::
Expand Down Expand Up @@ -505,7 +505,7 @@ def tabloid_gram_matrix(la, base_ring):
pulled back from the tabloid module.
For the module spanned by all tabloids, we define an bilinear form
by having the taboids be an orthonormal basis. We then pull this
by having the tabloids be an orthonormal basis. We then pull this
bilinear form back across the natural injection of the Specht module
into the tabloid module.
Expand Down Expand Up @@ -541,6 +541,20 @@ def simple_module_rank(la, base_ring):
sage: from sage.combinat.specht_module import simple_module_rank
sage: simple_module_rank([3,2,1,1], GF(3))
13
TESTS::
sage: from sage.combinat.specht_module import simple_module_rank
sage: simple_module_rank([1,1,1,1], GF(3))
Traceback (most recent call last):
...
ValueError: the partition [1, 1, 1, 1] is not 3-regular
sage: from sage.combinat.specht_module import simple_module_rank
sage: simple_module_rank([2,1], GF(3)['x'])
Traceback (most recent call last):
...
NotImplementedError: the base must be a field
"""
from sage.categories.fields import Fields
from sage.combinat.partition import Partition
Expand Down
4 changes: 4 additions & 0 deletions src/sage/combinat/symmetric_group_algebra.py
Original file line number Diff line number Diff line change
Expand Up @@ -1597,6 +1597,10 @@ def simple_module_dimension(self, la):
sage: SGA = SymmetricGroupAlgebra(GF(5), 6)
sage: SGA.simple_module_dimension(Partition([4,1,1]))
10
TESTS::
sage: SGA = SymmetricGroupAlgebra(GF(5), 6)
sage: SGA.simple_module_dimension(Partition([3,1,1]))
Traceback (most recent call last):
...
Expand Down

0 comments on commit 721b952

Please sign in to comment.