String pin numbers should be converted to type number when converting to tsx #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrii-balitskyi
changed the title
| ...pin, | ||
| pinNumber: newPinNumber, | ||
| label: pin.label, | ||
| } |
There was a problem hiding this comment.
Currently it looks like this, is it correct?
Or should it look like this?
There was a problem hiding this comment.
There's also a duplicate SH label. Should we check for duplicate labels and add some unique characters?
There was a problem hiding this comment.
Nope duplicates are ok!!!
There was a problem hiding this comment.
@seveibar my bad, should've marked the PR draft. There's some ghost code as I wanted to confirm the structure.
So, the first screenshot looks right?
There was a problem hiding this comment.
It should look like the second! Sorry for the delay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #80