Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convertEasyEdaJsonToCircuitJson: convert oval pads with hole radius to pill-shaped plated holes #83

Merged
merged 6 commits into from
Oct 25, 2024
Merged

convertEasyEdaJsonToCircuitJson: convert oval pads with hole radius to pill-shaped plated holes #83

merged 6 commits into from
Oct 25, 2024

Conversation

andrii-balitskyi
Copy link
Contributor

@andrii-balitskyi andrii-balitskyi commented Oct 23, 2024 •
edited
Loading

Closes #81

@andrii-balitskyi andrii-balitskyi changed the title convertEasyEdaJsonToCircuitJson: convert oval pads with hole radius to pill-shaped plated holes convertEasyEdaJsonToCircuitJson: convert oval pads with hole radius to pill-shaped plated holes Oct 23, 2024
andrii-balitskyi
andrii-balitskyi commented Oct 23, 2024
View reviewed changes
tests/convert-to-ts/__snapshots__/C165948-to-ts.snap.svg
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stroke width here should be fixed by #84

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 7b40650

seveibar
seveibar approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. It seems like we may have an issue in circuit to svg because the hole isnt tall enough? It should look almost like a coin slot

@andrii-balitskyi
Copy link
Contributor Author

andrii-balitskyi commented Oct 24, 2024 •
edited
Loading

@seveibar not sure about that. Could be an issue in circuit to svg. But to be sure, am I calculating the props correctly here?

@seveibar seveibar merged commit 6a839de into main Oct 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seveibar seveibar seveibar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

C165948 - Should generate pills instead of circle plated holes in usb c connector
2 participants
@andrii-balitskyi @seveibar