-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pactus]: Support Pactus Blockchain #4057
Open
b00f
wants to merge
14
commits into
trustwallet:master
Choose a base branch
from
pactus-project:pactus
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I hope this message finds you well! If you have a moment, I would greatly appreciate your review of this pull request. Please let us know if there’s anything we might have missed that needs attention before we proceed with the merge. Thank you very much for your assistance! |
Hey @b00f He will review the PR next week - thank you |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for the Pactus Blockchain in TrustWalletCore.
It follows the Integration Criteria highlighted by TrustWalletCore team.
How to test
This PR includes all the necessary tests to ensure the integration is done properly.
We have also compared the results with the native wallet in Pactus, which is available here and here.
This PR fixes #4056 .
Types of changes
New feature (non-breaking change which adds functionality)
Checklist
Integration Checklist
registry.json
.pushd codegen-v2 && cargo run -- new-blockchain <coinid> && popd
to generate blockchain skeleton and configure integration tests.tools/generate-files
.pushd rust && cargo check --tests && popd
to check if Rust codebase compiles successfully.make -Cbuild -j12 tests TrezorCryptoTests
to check if C++ codebase compiles successfully.Curve
,Hasher
etc., in C++ and Rust, as necessary.rust/chains/tw_<coinid>/src/entry.rs
.rust/chains/tw_<coinid>/src/address.rs
.rust/chains/tw_<coinid>/src/transaction.rs
.rust/chains/tw_<coinid>/src/signer.rs
.rust/chains/tw_<coinid>/src/compiler.rs
.rust/chains/tw_<coinid>/tests
directory.rust/tw_any_coin/tests/chains/<coinid>
tests/chains/<CoinId>
.CoinAddressDerivationTests.cpp
andcoin_address_derivation_test.rs
,CoinAddressValidationTests.cpp
,TWHRPTests.cpp
,CoinAddressDerivationTests.kt
,CoinAddressDerivationTests.swift
.