[BTC]: Add support for signPSBT
#4032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* TODO add support for signing of `non_witness_utxo` * TODO add support for PSBT planning
* Add `ChainInfo.hrp`
Binary size comparison➡️ aarch64-apple-ios: - 12.09 MB
+ 12.14 MB +53 KB➡️ aarch64-apple-ios-sim: - 12.09 MB
+ 12.15 MB +53 KB➡️ aarch64-linux-android: - 15.50 MB
+ 15.58 MB +79 KB➡️ armv7-linux-androideabi: - 13.24 MB
+ 13.30 MB +57 KB➡️ wasm32-unknown-emscripten: - 10.98 MB
+ 11.04 MB +61 KB |
Milerius
approved these changes
Sep 24, 2024
|
Loos great @satoshiotomakan !!! . Quick question, is BIP0322 going to be handled separetly? Thanks ! |
|
Hi @JaimeToca, BIP0322 will be released separately |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for a limited Bitcoin PSBT signing/planning support.
It includes: P2PK, P2PKH, P2WPKH, P2TR (key-path) UTXO signing. Please note P2SH, P2WSH, P2TR (script-path) are not supported yet.
How to test
Run Rust, C++, Swift, Kotlin tests
Types of changes
TWBitcoinPsbtSignFFI that takesBitcoinV2.PsbtSigningInputand returnsBitcoinV2.PsbtSigningOutputTWBitcoinPsbtPlanFFI that takesBitcoinV2.PsbtSigningInputand returnsBitcoinV2.TransactionPlan- it can be used to get the transaction details such as fee, inputs and outputs amounts/addresses/scriptPubkeys.rust/tw_any_coin/teststorust/tw_tests/testsChecklist
If you're adding a new blockchain