Fix nullptr dereference when not calling JNI_OnLoad on Android #3984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henriqueaklein
requested review from
Milerius,
satoshiotomakan and
ar-g
as code owners
satoshiotomakan
requested changes
Aug 14, 2024
There was a problem hiding this comment.
Hi @henriqueaklein, thank you for opening the PR! Please consider making a little change
satoshiotomakan
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is applicable to loading the wallet-core on Android using the library directly instead of JNI.
Without calling JNI_OnLoad the jvm pointer is NULL, so any attempt to use it in random_buffer will result in a nullptr dereference.
In addition to preventing the crash, the Unix compatible implementation was used as an alternative when using the library directly.