feat: add solana token 2022 support

[weixuefeng]

fix: #3934

[satoshiotomakan]

Hi @weixuefeng, thank you for opening the PR.
Please also fix rustfmt and(?) clippy warnings

[satoshiotomakan]

Could you please revert the keys sorting? Even though, they're sorted in official Solana lib, but in WalletCore I disabled it explicitly to save backward compatibility to have the same transaction signature after the Rust transition.
Please note that the keys are not required to be sorted to be valid transaction

[satoshiotomakan]

Same here

[satoshiotomakan]

Same here

[satoshiotomakan]

You can ignore is_token_2022 field here as ..Proto::CreateAndTransferToken::default() leaves it default (false) value. Same in other places

[satoshiotomakan]

@weixuefeng I can push the fix commit if you're ok, just let me know

[weixuefeng]

@weixuefeng I can push the fix commit if you're ok, just let me know

updated. @satoshiotomakan

[satoshiotomakan]

I can't push fix commits, so please run cargo fmt at the rust directory. Please also make sure all tests pass, and cargo clippy do not produce warnings

[satoshiotomakan]

Hi @weixuefeng, did you have a chance to fix the formatting by running cargo fmt and cargo clippy?

[weixuefeng]

Hi @weixuefeng, did you have a chance to fix the formatting by running cargo fmt and cargo clippy?

only fix cargo fmt and cargo clippy. but rust test have some error. i don't know how can i generate signature. and the preImageHash for transaction is different. i have not resolve it.

[satoshiotomakan]

Hi @weixuefeng, do you mean you can fix test_solana_sign_create_and_transfer_token_2022 and test_solana_sign_transfer_token_2022 tests after removing the keys reordering? You can regenerate and rebroadcast the transactions.
Other tests should pass since there is no breaking changes anymore if is_token_2022: false

[weixuefeng]

Hi @weixuefeng, do you mean you can fix test_solana_sign_create_and_transfer_token_2022 and test_solana_sign_transfer_token_2022 tests after removing the keys reordering? You can regenerate and rebroadcast the transactions. Other tests should pass since there is no breaking changes anymore if is_token_2022: false

yes. removing the keys reordering can broadcast success on devnet.

but there have some problem. i have not found the problem about test_solana_compile_create_and_transfer_token_with_external_fee_payer testcase.
@satoshiotomakan

[0xh3rman]

@weixuefeng @satoshiotomakan Maybe it's better to create an enum for token standard? not bool type or we can pass the token program as an argument in protobuf model cause it seems compatible with Token Program

[weixuefeng]

@weixuefeng @satoshiotomakan Maybe it's better to create an enum for token standard? not bool type or we can pass the token program as an argument in protobuf model cause it seems compatible with Token Program

I think tokenProgramId is very slow to update, so I stick with bool value. How about refactoring if there are more programId in the future?
@0xh3rman

[weixuefeng]

Please check update. @satoshiotomakan

[satoshiotomakan]

Hi @weixuefeng, I agree with @0xh3rman, could you please add an enum in Solana.proto. Please make a few small changes as well

[0xh3rman]

LGTM

[satoshiotomakan]

Hi @weixuefeng, could you please format the code using cargo fmt? Please also make sure cargo clippy doesn't produce warnings, and all tests pass. I'm sure there is no breaking changes, so test_solana_compile_create_and_transfer_token_with_external_fee_payer should also pass without problems

[satoshiotomakan]

LGTM