Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TrezorCrypto CMake build #3911

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Fix TrezorCrypto CMake build #3911

merged 2 commits into from
Aug 7, 2024
+2 −0

Conversation

EduMenges
Copy link
Contributor

@EduMenges EduMenges commented Jun 20, 2024 •
edited
Loading

The _Static_assert requires C11, which is not correctly set on CMake.

@satoshiotomakan
Copy link
Collaborator

Hi @EduMenges, would set (CMAKE_CXX_STANDARD 11) work as well?

@EduMenges
Copy link
Contributor Author

No, that would not work because the files for TrezorCrypto are compiled with the C compiler, not the C++ compiler.

@satoshiotomakan satoshiotomakan merged commit 0b6bbbb into trustwallet:master Aug 7, 2024
12 checks passed
@EduMenges EduMenges deleted the fix-trezor-crypto-cmake branch August 14, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Milerius Milerius Awaiting requested review from Milerius Milerius is a code owner

@satoshiotomakan satoshiotomakan Awaiting requested review from satoshiotomakan satoshiotomakan is a code owner

@ar-g ar-g Awaiting requested review from ar-g ar-g is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EduMenges @satoshiotomakan