Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc]: Fix C++ includes on Linux #3755

Merged
merged 8 commits into from
Mar 22, 2024
Merged

[Misc]: Fix C++ includes on Linux #3755

merged 8 commits into from
Mar 22, 2024

Conversation

satoshiotomakan
Copy link
Collaborator

@satoshiotomakan satoshiotomakan commented Mar 22, 2024

Description

Fix C++ includes broken at #3751

How to test

Types of changes

Checklist

  • Create pull request as draft initially, unless its complete.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description.

If you're adding a new blockchain

  • I have read the guidelines for adding a new blockchain.

@satoshiotomakan satoshiotomakan marked this pull request as ready for review March 22, 2024 09:36
@satoshiotomakan satoshiotomakan changed the title [WIP]: Fix C++ includes on Linux [Misc]: Fix C++ includes on Linux Mar 22, 2024
Copy link

github-actions bot commented Mar 22, 2024

Binary size comparison

➡️ aarch64-apple-ios: 11.34 MB

➡️ aarch64-apple-ios-sim: 11.34 MB

➡️ aarch64-linux-android: 14.60 MB

➡️ armv7-linux-androideabi: 12.29 MB

➡️ wasm32-unknown-emscripten: 10.08 MB

Milerius
Milerius previously approved these changes Mar 22, 2024
@satoshiotomakan satoshiotomakan marked this pull request as ready for review March 22, 2024 16:19
@satoshiotomakan satoshiotomakan merged commit 2de1a62 into master Mar 22, 2024
11 of 12 checks passed
@satoshiotomakan satoshiotomakan deleted the s/cpp-hotfix branch March 22, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants