[Aptos]: Add transfer_coins function call
#3344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…transfer_coins` function * Add test with testnet transaction
Milerius
previously approved these changes
Aug 1, 2023
lamafab
reviewed
Aug 1, 2023
android/app/src/androidTest/java/com/trustwallet/core/app/blockchains/aptos/TestAptosSigner.kt
Outdated
Show resolved
Hide resolved
android/app/src/androidTest/java/com/trustwallet/core/app/blockchains/aptos/TestAptosSigner.kt
Show resolved
Hide resolved
lamafab
previously approved these changes
Aug 1, 2023
Milerius
approved these changes
Aug 2, 2023
Milerius
added a commit
that referenced
this pull request
Aug 11, 2023
* [NewChain/Base]: add base blockchain (#3342) * [Aptos]: Add `transfer_coins` function call (#3344) * feat(aptos): Add `TokenTransferCoinsMessage` to call `aptos_account::transfer_coins` function * Add test with testnet transaction * feat(aptos): Add mainnet test * feat(aptos): Fix comment * [Bitcoin] Fix `TWBitcoinFeeCalculateFee` (for JavaScript) (#3346) * [Barz] Allow deriving multiple addresses from a single public key (#3340) * [Barz] Allow deriving multiple addresses from a single public key * fix tests * Update BarzTests.swift * update tests * update tests * update tests * [ETH]: Handle `tuple[]` ABI type parameter (#3352) --------- Co-authored-by: Sztergbaum Roman <[email protected]> Co-authored-by: Fabio Lama <[email protected]> Co-authored-by: Ruslan Serebriakov <[email protected]>
satoshiotomakan
added a commit
that referenced
this pull request
Oct 6, 2023
* [NewChain/Base]: add base blockchain (#3342) * [Aptos]: Add `transfer_coins` function call (#3344) * feat(aptos): Add `TokenTransferCoinsMessage` to call `aptos_account::transfer_coins` function * Add test with testnet transaction * feat(aptos): Add mainnet test * feat(aptos): Fix comment * [Bitcoin] Fix `TWBitcoinFeeCalculateFee` (for JavaScript) (#3346) * [Barz] Allow deriving multiple addresses from a single public key (#3340) * [Barz] Allow deriving multiple addresses from a single public key * fix tests * Update BarzTests.swift * update tests * update tests * update tests * [ETH]: Handle `tuple[]` ABI type parameter (#3352) --------- Co-authored-by: Sztergbaum Roman <[email protected]> Co-authored-by: Fabio Lama <[email protected]> Co-authored-by: Ruslan Serebriakov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the ability to transfer tokens even if the recipient has not registered them yet by using
0x1::aptos_account::transfer_coins.How to test
Run C++, Kotlin tests
Types of changes
Add
TokenTransferCoinsMessagesimilar toTokenTransferMessage.Checklist
If you're adding a new blockchain