[Barz] Allow deriving multiple addresses from a single public key #3340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsrbk
requested review from
Milerius,
satoshiotomakan and
lamafab
as code owners
|
@rsrbk please fix Android tests |
lamafab
previously approved these changes
Jul 28, 2023
|
ios test is not passing @rsrbk |
rsrbk
force-pushed
the
rsrbk/barz-accounts-derivation
branch
from
6a3663b
to
445ee3c
Compare
|
tests fixed |
Milerius
approved these changes
Aug 4, 2023
satoshiotomakan
approved these changes
Aug 4, 2023
Milerius
added a commit
that referenced
this pull request
Aug 11, 2023
* [NewChain/Base]: add base blockchain (#3342) * [Aptos]: Add `transfer_coins` function call (#3344) * feat(aptos): Add `TokenTransferCoinsMessage` to call `aptos_account::transfer_coins` function * Add test with testnet transaction * feat(aptos): Add mainnet test * feat(aptos): Fix comment * [Bitcoin] Fix `TWBitcoinFeeCalculateFee` (for JavaScript) (#3346) * [Barz] Allow deriving multiple addresses from a single public key (#3340) * [Barz] Allow deriving multiple addresses from a single public key * fix tests * Update BarzTests.swift * update tests * update tests * update tests * [ETH]: Handle `tuple[]` ABI type parameter (#3352) --------- Co-authored-by: Sztergbaum Roman <[email protected]> Co-authored-by: Fabio Lama <[email protected]> Co-authored-by: Ruslan Serebriakov <[email protected]>
satoshiotomakan
added a commit
that referenced
this pull request
Oct 6, 2023
* [NewChain/Base]: add base blockchain (#3342) * [Aptos]: Add `transfer_coins` function call (#3344) * feat(aptos): Add `TokenTransferCoinsMessage` to call `aptos_account::transfer_coins` function * Add test with testnet transaction * feat(aptos): Add mainnet test * feat(aptos): Fix comment * [Bitcoin] Fix `TWBitcoinFeeCalculateFee` (for JavaScript) (#3346) * [Barz] Allow deriving multiple addresses from a single public key (#3340) * [Barz] Allow deriving multiple addresses from a single public key * fix tests * Update BarzTests.swift * update tests * update tests * update tests * [ETH]: Handle `tuple[]` ABI type parameter (#3352) --------- Co-authored-by: Sztergbaum Roman <[email protected]> Co-authored-by: Fabio Lama <[email protected]> Co-authored-by: Ruslan Serebriakov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Salt is passed to functions as a parameter now instead of being hardcoded to 0