Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add Neon Mainnet Network #3334

Merged
merged 4 commits into from
Jul 27, 2023
Merged

Feat: Add Neon Mainnet Network #3334

merged 4 commits into from
Jul 27, 2023

Conversation

joehquak
Copy link
Contributor

@joehquak joehquak commented Jul 26, 2023

Description

This PR adds Neon EVM to the Trust Wallet supported RPCs

How to test

./tools/build-and-test

[==========] 2374 tests from 579 test suites ran. (54854 ms total)
[  PASSED  ] 2374 tests.

Types of changes

Adds Neon EVM mainnet chain
https://docs.neonfoundation.io/docs/developing/connect_rpc
https://neonevm.org

Checklist

  • Create pull request as draft initially, unless its complete.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description.

If you're adding a new blockchain

  • I have read the guidelines for adding a new blockchain.

Copy link
Collaborator

@satoshiotomakan satoshiotomakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the new blockchain. One question

registry.json Outdated Show resolved Hide resolved
@satoshiotomakan
Copy link
Collaborator

@joehquak please also fix Android and iOS tests. You can run them using Android studio and XCode.
Or by typing

./tools/android-test
./tools/ios-test

@joehquak
Copy link
Contributor Author

@joehquak please also fix Android and iOS tests. You can run them using Android studio and XCode. Or by typing

./tools/android-test
./tools/ios-test

Will do so now, thank you 🙏

@joehquak
Copy link
Contributor Author

@satoshiotomakan Should be ready now I hope 😁

@Milerius Milerius merged commit 019ada6 into trustwallet:master Jul 27, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants