Improve eth_sign compatibility (#102)

* eth_sign behaves like personal_sign * add eth_sign test
trustwallet · Sep 27, 2020 · d75dfef · d75dfef
1 parent 8f3c374
commit d75dfef
Show file tree

Hide file tree

Showing 6 changed files with 292 additions and 38 deletions.
diff --git a/dist/trust-min.js b/dist/trust-min.js
diff --git a/src/index.js b/src/index.js
@@ -12,6 +12,7 @@ import ProviderRpcError from "./error";
 import Utils from "./utils";
 import IdMapping from "./id_mapping";
 import { EventEmitter } from "events";
+import isUtf8 from 'isutf8';
 
 class TrustWeb3Provider extends EventEmitter {
   constructor(config) {
@@ -200,7 +201,19 @@ class TrustWeb3Provider extends EventEmitter {
   }
 
   eth_sign(payload) {
-    this.postMessage("signMessage", payload.id, {data: payload.params[1]});
+    const data = payload.params[1];
+    var buffer;
+    if ((typeof (data) === "string")) {
+      buffer = Utils.hexToBuffer(data);
+    } else {
+      buffer = Buffer.from(data);
+    }
+    const hex = buffer.toString('hex');
+    if (isUtf8(buffer)) {
+      this.postMessage("signPersonalMessage", payload.id, {data: hex});
+    } else {
+      this.postMessage("signMessage", payload.id, {data: hex});
+    }
   }
 
   personal_sign(payload) {

diff --git a/src/package-lock.json b/src/package-lock.json