ethpmV3 support

[njgheorghita]

Truffle support for the ethpmV3 spec!

Hey @gnidan and @eggplantzzz . Thanks for your help so far in discussing this. Here's a first pass at ethpmV3 x truffle. I'm sure there's plenty of areas where my javascript is smelly, please point them out anywhere you see them. After a review, I plan to run this through another thorough round of integration tests, & I have an update to the trufflesuite.com docs in the pipeline to reflect these changes.

[njgheorghita]

I'm happy to deploy an un-authenticated registry for truffle to use as its default, unless you guys want to handle that. I'm 50/50 on whether it should be on mainnet (better reliability / authority / helps minimize spam packages) or on any testnet (much much cheaper / easier to start getting your hands dirty with publishing ethpm packages)

[gnidan]

does this field respect ENS names?

[njgheorghita]

Yep, though right now it only permits ens on mainnet. However, upon further investigation it looks like truffle supports ens on all testnets except kovan, so I updated it to support ens on these other testnets.

[njgheorghita]

It seems like there might be a better mechanism available somewhere in truffle that manages sending txs with a more user-friendly interface? Could you point me in the right direction...

[gnidan]

Here's an initial review on the @truffle/core plumbing stuff

[gnidan]

does this field respect ENS names?

[gnidan]

Suggested change

	usage: "truffle install <packageId> [--alias]",
	usage: "truffle install <package-identifier> [--alias]",

[njgheorghita]

@eggplantzzz Thanks for the review! I've changed or responded to your comments. Let me know if there's anything else glaring / obvious that needs addressing. In terms of the failing tests... Has there been any significant changes to the resolver recently? It seems to me that the await Migrate.run(config) step is failing in the tests - and it's not obvious the best way to fix it, but I'll be able to dig a little deeper into it tomorrow if it's not obvious to you what changed.

[eggplantzzz]

Sorry about jerking you back and forth on the package-identifier stuff, I didn't see @gnidan's suggestion about it until afterwards haha.

[eggplantzzz]

As for the CI failures, I don't think anything changed with the migrations. I'll take a quick look and see if I can find anything out about this.

[eggplantzzz]

So @njgheorghita, I took a look and your tests are failing because there were a bunch of breaking changes to some of the compilation packages. workflow-compile had compilation and the saving of artifacts separated into two steps. I made the necessary corrections and pushed them to a branch in the Truffle repo called fix-ethpm-tests. I didn't want to push directly to your branch but feel free to merge it into yours or fix it yourself. The gist of the matter is that Contracts.compile no longer saves the artifacts. There is now a method Contracts.compileAndSave that you need to use to do both. We also started using WorkflowCompile as the name when importing that library and I made that change in there as well. Let me know if something is unclear or if you need anything else!

[njgheorghita]

@eggplantzzz Nailed it! Thanks for looking into it and the fix!

[njgheorghita]

@eggplantzzz I can definitely update packageIdentifier -> package_identifier. Just to make sure I'm not messing up anything here - what's the reason to merge the develop branch into this one? Is it fine to continue building on top of it?

[njgheorghita]

I've also updated the ethpm x truffle docs here and added my blog (which is fairly similar to the docs but has a better example and more in-depth analysis) here.

[eggplantzzz]

@njgheorghita Oh, I think there was just a merge conflict so I resolved it for you. I hope you don't mind...sorry if I stepped on your toes. It should be fine to continue as normal. And thanks for the fix!