PR feedback

packages/core/index.js

@@ -4,7 +4,6 @@ const pkg = require("./package.json");
 module.exports = {
   build: require("./lib/build"),
   create: require("./lib/commands/create/helpers"),
-  console: require("./lib/repl"),
   // TODO: update this to non-legacy the next breaking change
   contracts: require("@truffle/workflow-compile/legacy"),
   test: require("./lib/testing/Test"),

packages/core/lib/commands/install.js

@@ -5,11 +5,11 @@ const command = {
   description: "Install a package from the Ethereum Package Registry",
   builder: {},
   help: {
-    usage: "truffle install <package-identifier> [--alias]",
+    usage: "truffle install <packageIdentifier> [--alias]",
     options: [
       {
         option: "packageIdentifier",
-        description: `(required) Name of the package as listed in the Ethereum Package Registry. Accepted formats: packageName, packageName@version, ethpm URI, ipfs URI.`
+        description: `Name of the package as listed in the Ethereum Package Registry. Accepted formats: packageName, packageName@version, ethpm URI, ipfs URI. (required)`
       },
       {
         option: "--alias",
@@ -39,16 +39,16 @@ const command = {
     options.packageIdentifier = options._[0];
 
     const config = Config.detect(options);
-    let callbackFunction;
+    let installPackage;
 
     if (config.ethpm.version == "1") {
-      callbackFunction = callbackify(PackageV1.install);
+      installPackage = callbackify(PackageV1.install);
     } else if (config.ethpm.version == "3") {
-      callbackFunction = callbackify(PackageV3.install);
+      installPackage = callbackify(PackageV3.install);
     } else {
       done(new Error(`Unsupported ethpm version: ${config.ethpm.version}.`));
     }
-    callbackFunction(config, done);
+    installPackage(config, done);
   }
 };
 

packages/core/lib/commands/packages.js

@@ -1,6 +1,6 @@
 const { callbackify } = require("util");
 
-var command = {
+const command = {
   command: "packages",
   description: "List available packages on connected EthPM Registry",
   builder: {},
@@ -9,21 +9,21 @@ var command = {
     options: []
   },
   run: function (options, done) {
-    var Config = require("@truffle/config");
-    var PackageV1 = require("@truffle/ethpm-v1");
-    var PackageV3 = require("@truffle/ethpm-v3");
+    const Config = require("@truffle/config");
+    const PackageV1 = require("@truffle/ethpm-v1");
+    const PackageV3 = require("@truffle/ethpm-v3");
 
-    var config = Config.detect(options);
-    let callbackFunction;
+    const config = Config.detect(options);
+    let listPackages;
 
     if (config.ethpm.version == "1") {
-      callbackFunction = callbackify(PackageV1.packages);
+      listPackages = callbackify(PackageV1.packages);
     } else if (config.ethpm.version == "3") {
-      callbackFunction = callbackify(PackageV3.packages);
+      listPackages = callbackify(PackageV3.packages);
     } else {
       done(new Error(`Unsupported ethpm version: ${config.ethpm.version}.`));
     }
-    callbackFunction(config, done);
+    listPackages(config, done);
   }
 };
 

packages/core/lib/commands/publish.js

@@ -1,6 +1,6 @@
 const { callbackify } = require("util");
 
-var command = {
+const command = {
   command: "publish",
   description: "Publish a package to the Ethereum Package Registry",
   builder: {},
@@ -9,21 +9,21 @@ var command = {
     options: []
   },
   run: function (options, done) {
-    var Config = require("@truffle/config");
-    var PackageV1 = require("@truffle/ethpm-v1");
-    var PackageV3 = require("@truffle/ethpm-v3");
+    const Config = require("@truffle/config");
+    const PackageV1 = require("@truffle/ethpm-v1");
+    const PackageV3 = require("@truffle/ethpm-v3");
 
-    var config = Config.detect(options);
-    let callbackFunction;
+    const config = Config.detect(options);
+    let publishPackage;
 
     if (config.ethpm.version == "1") {
-      callbackFunction = callbackify(PackageV1.publish);
+      publishPackage = callbackify(PackageV1.publish);
     } else if (config.ethpm.version == "3") {
-      callbackFunction = callbackify(PackageV3.publish);
+      publishPackage = callbackify(PackageV3.publish);
     } else {
       done(new Error(`Unsupported ethpm version: ${config.ethpm.version}.`));
     }
-    callbackFunction(config, done);
+    publishPackage(config, done);
   }
 };