Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Add support for eth_signTypedData_v4 #607

Closed
wants to merge 1 commit into from

Conversation

dmihal
Copy link

@dmihal dmihal commented Aug 14, 2020

Add's support for the eth_signTypedData_v4 RPC method. Also supports signing typed data where the payload is a string (which is how many nodes expect it).

@davidmurdoch
Copy link
Member

@dmihal do you know of nodes that have implemented eth_signTypedData and/or eth_signTypedData_v4?

@dmihal
Copy link
Author

dmihal commented Aug 17, 2020

@davidmurdoch Looks like Geth has eth_signTypedData, but not eth_signTypedData_v4

However, metamask includes eth_signTypedData_v4

@gnidan
Copy link
Contributor

gnidan commented Mar 24, 2021

Hey @dmihal sorry to drop the ball on this. Do you know if the situation around this method has changed at all? Does geth support it yet (e.g.)?

Regardless, for this PR, it might make sense to target develop now, which represents the upcoming Ganache v7.0.0 release. We could get this into the existing major release, but we are seeking to move forward.

Also it might be worth noting that it's been a long time since August of last year; this v4 method might already exist but without the _v4 suffix. Sounds like we'll need to do some investigation.

Thanks!

@gnidan gnidan added this to the 7.1.0 milestone Mar 24, 2021
@hasandogu
Copy link

Any updates on getting this into the build?

@davidmurdoch
Copy link
Member

davidmurdoch commented Nov 18, 2021

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants