[feat] - Introduce Fatal/Non-Fatal File Handling Errors #3521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosecodym
approved these changes
Oct 29, 2024
| @@ -351,7 +361,7 @@ func HandleFile( | |||
| // handleChunksWithError processes data and errors received from the dataErrChan channel. | |||
| // For each DataOrErr received: | |||
| // - If it contains data, the function creates a chunk based on chunkSkel and reports it through the reporter. | |||
| // - If it contains an error, the function logs the error. | |||
| // - If it contains an error, the function returns the error immediately. | |||
There was a problem hiding this comment.
This is for fatal errors, right? This comment seems like a good place to explain non-fatal errors as well. I would also like in some comment somewhere a description of what types of errors are fatal versus non-fatal - maybe in the doc comments of functions that use DataOrErr?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR addresses the third point in this comment.
Checklist:
make test-community)?make lintthis requires golangci-lint)?