Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore invalid MongoDB connection strings #3440

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rgmz
Copy link
Contributor

@rgmz rgmz commented Oct 16, 2024

Description:

This ignores matches for MongoDB that are not valid URLs and can never succeed verification.

Found unverified result πŸ·πŸ”‘β“
Verification issue: net/url: invalid userinfo
Detector Type: MongoDB
Decoder Type: PLAIN
Raw result: mongodb+srv://<user>:<password>@myMongoCluster.mongocluster.cosmos.azure.com
Rotation_guide: https://howtorotate.com/docs/tutorials/mongo/
Commit: 23ddc72b02c957662d1e7b51914dd90bad6adeb0
Email: Peng Jiahui <[email protected]>
File: sdk/resourcemanager/cosmos/armcosmos/mongoclusters_client_example_test.go
Line: 453
Link: https://github.com/Azure/azure-sdk-for-go/blob/23ddc72b02c957662d1e7b51914dd90bad6adeb0/sdk/resourcemanager/cosmos/armcosmos/mongoclusters_client_example_test.go#L453
Repository: https://github.com/Azure/azure-sdk-for-go.git
Timestamp: 2023-11-27 08:12:14 +0000

It's also a fix/follow-up to #2518. The connection string's query parameters and path should not be discarded.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants