Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] - use DetectorKey as the key in the detectorKeysWithResults map #2366

Merged
merged 3 commits into from
Feb 2, 2024
Merged

[bug] - use DetectorKey as the key in the detectorKeysWithResults map #2366

merged 3 commits into from
Feb 2, 2024

Conversation

ahrav
Copy link
Collaborator

@ahrav ahrav commented Feb 2, 2024

Description:

The current map key contains unhashable fields. Use the DetectorKey instead as the key in the map.

Screenshot 2024-02-02 at 12 37 54 PM

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

zricethezav
zricethezav reviewed Feb 2, 2024
View reviewed changes
pkg/engine/engine.go Outdated Show resolved Hide resolved
@ahrav ahrav marked this pull request as ready for review February 2, 2024 21:13
@ahrav ahrav requested a review from a team as a code owner February 2, 2024 21:13
@ahrav ahrav merged commit 382990a into main Feb 2, 2024
10 checks passed
@ahrav ahrav deleted the bug-unhashble-map-key branch February 2, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zricethezav zricethezav zricethezav approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahrav @zricethezav