Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Postgres detector #2301

Closed
wants to merge 5 commits into from
Closed

Fix Postgres detector #2301

wants to merge 5 commits into from

Conversation

rosecodym
Copy link
Collaborator

@rosecodym rosecodym commented Jan 12, 2024

Description:

  • Use all found URIs in a chunk, rather than just the first one
  • Test locally on a port other than 5433, because that one can have local dev problems
  • Stop manufacturing candidate secrets with "localhost" as a candidate host
    • ignore if it it's in the chunk
    • don't conjure it up as a default
  • Make it so that if "localhost" is found in a chunk, the "host" part of it doesn't trigger the host detection pattern

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@rosecodym rosecodym changed the title Fix Postgres multi url Fix Postgres detector Jan 12, 2024
@rosecodym
Copy link
Collaborator Author

closed in favor of #2314

@rosecodym rosecodym closed this Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant