Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix forks and repos counter, add metric for orgs enumerated #2118

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

dustin-decker
Copy link
Contributor

@dustin-decker dustin-decker commented Nov 20, 2023

Fixes a counter and adds a new metric for orgs enumerated. If we used the orgs cache for enumeration with app I would have gotten the count there instead. The metric is needed to confirm that a customer integration migration is performing as expected.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@dustin-decker dustin-decker requested a review from a team as a code owner November 20, 2023 21:51
@rgmz
Copy link
Contributor

rgmz commented Nov 20, 2023

num_members also seems to be broken, only showing 0.

@@ -220,7 +222,16 @@ func (s *Source) processRepos(ctx context.Context, target string, listRepos repo
if r.GetFork() && !s.conn.IncludeForks {
continue
}
numForks++

if r.GetFork() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this.

@dustin-decker dustin-decker merged commit 75e869f into main Nov 21, 2023
9 checks passed
@dustin-decker dustin-decker deleted the github-org-metric branch November 21, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants