Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update protos so we can use the git source for CI #2102

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

ahrav
Copy link
Collaborator

@ahrav ahrav commented Nov 8, 2023

Description:

These changes allow us to specify the fields necessary to scan Git in CI via a config.yaml.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@ahrav ahrav requested a review from a team as a code owner November 8, 2023 16:43
Copy link
Collaborator

@bill-rich bill-rich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this so we can use Chunks rather than doing all the ScanOptions setup manually?

@ahrav
Copy link
Collaborator Author

ahrav commented Nov 8, 2023

Is this so we can use Chunks rather than doing all the ScanOptions setup manually?

That wasn't the initial intent but that would work. This was so that we can provide --since-commit and --branch options in a config.yaml for enterprise so we can use the scan subcommand vs the git subcommand. This then allows for results to be displayed in their dashboard as well. Given the git subcommand doesn't connect to the api, but scan does.

@ahrav ahrav requested a review from bill-rich November 8, 2023 16:52
@ahrav ahrav merged commit 76a0468 into main Nov 8, 2023
9 checks passed
@ahrav ahrav deleted the update-git-protos branch November 8, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants