extract AWS account number from ID without verification #2091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeleonjr
changed the title
ahrav
approved these changes
Nov 4, 2023
ahrav
reviewed
Nov 4, 2023
rosecodym
reviewed
Nov 7, 2023
It should. I'm going to move this function into the common lib, so that we can re-use it across that separate detector. |
|
@ahrav do you mind doing another quick review now that the code has been refactored and moved to utils? |
rosecodym
approved these changes
Nov 16, 2023
forgot to reply yesterday, but LGTM! Nice work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Research by Tal Be'ery documented how to extract AWS account numbers from AWS IDs (ex:
AKIASP2TPHJSQH3FJRUX->171436882533) without having to interact with the AWS API.I ported his python function to golang, added error handling, updated logic in the
aws.gofile and updated the aws integration tests.Note: if AWS secret verification is successful, the calculated AWS account number gets overwritten by the API's account number response. These values should always be the same.
Also, commented out is a suggestion that we log situations where the calculated account number does not match the API-verified account number. This should rarely (if ever) occur; however, if we can monitor this, that would be helpful to verify accuracy at scale.
Checklist:
make test-community)?make lintthis requires golangci-lint)?