Refactor git source to support scanning units #2083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcastorina
force-pushed
the
git-unit-refactor
branch
from
ef89775
to
ce6d364
Compare
2 tasks
rosecodym
approved these changes
Nov 1, 2023
Comment on lines
+83
to
+87
| var _ interface { | ||
| sources.Source | ||
| sources.SourceUnitEnumChunker | ||
| sources.SourceUnitUnmarshaller | ||
| } = (*Source)(nil) |
There was a problem hiding this comment.
whoa i didn't know you could smoosh interfaces together like this
There was a problem hiding this comment.
It's an anonymous interface composed of other interfaces! Similar to interface{} (aka any) but with stuff in it.
mcastorina
force-pushed
the
git-unit-refactor
branch
from
ce6d364
to
253658a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds functions for scanning a single repo or directory as well as all the required methods for unit chunking.
Checklist:
make test-community)?make lintthis requires golangci-lint)?