[chore] - correctly handle input shorter than 512 bytes #2077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahrav
commented
Oct 31, 2023
| "github.com/stretchr/testify/assert" | ||
| diskbufferreader "github.com/trufflesecurity/disk-buffer-reader" |
There was a problem hiding this comment.
Note: not sure how/why this got updated, but i'm going to leave it since its just a import reorder.
mcastorina
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Check for EOF error as well as err != nil so that input shorter than 512 bytes is also correctly processed.
Checklist:
make test-community)?make lintthis requires golangci-lint)?