Centralize logic for checking archive extraction tools

[ahrav]

Description:

Only check for archive extraction tools once during init. Reuse the cache during scans to prevent unnecessary filesystem lookups.

Checklist:

• Tests passing (make test-community)?
• Lint passing (make lint this requires golangci-lint)?

[mcastorina]

Are we using isToolInstalled for any tool besides the ones we already know about? I'm not sure it's worth the added complexity to support that use case.

[mcastorina]

Have you considered setting some configuration flag in Archive for control flow in HandleSpecialized, for example?

[ahrav]

Have you considered setting some configuration flag in Archive for control flow in HandleSpecialized, for example?

What were you thinking of? I haven't really thought too hard about this, other than noticing we checked if we had tools installed for every file 😓

[mcastorina]

What were you thinking of?

Something like..

func init() {
    if !archiveToolsInstalled {
        disableArchiveHandler()
    }
}

or the inverse? I also haven't thought too deeply on it.

[ahrav]

What were you thinking of?

Something like..

func init() {
    if !archiveToolsInstalled {
        disableArchiveHandler()
    }
}

or the inverse? I also haven't thought too deeply on it.

Ahhh yea I hadn't thought of that. I guess it would involve a little more logic b/c what I touched was a very specific part of the archive handler that relates only to .deb and .rpm files. The archive handler also handles all other archive file types out of the box using the archiver library. We just have to use rpm2cpio and ar to extract certain archives and then feed it into the archiver lib.

So your idea would work, we'd just have to exclude certain archive types but not necessarily all.