use rawv2 for pubnubpublish #2062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosecodym
commented
Oct 30, 2023
| @@ -55,6 +55,7 @@ func (s Scanner) FromData(ctx context.Context, verify bool, data []byte) (result | |||
| s1 := detectors.Result{ | |||
| DetectorType: detectorspb.DetectorType_PubNubPublishKey, | |||
| Raw: []byte(resMatch), | |||
| RawV2: []byte(resMatch + "/" + ressubMatch), | |||
There was a problem hiding this comment.
Most multipart secret detectors just splice the two parts together, which seems unwise to me, so I used / as a separator because that's how the secrets are combined in the URL during verification. A few other detectors use : as a separator; if that's a convention we're trying to follow I'm happy to change it.
There was a problem hiding this comment.
For getting a password hash of the value it doesn't really matter, as long as we include all the parts, but if we ever wanted to parse the field it does. I think the ship has sailed on making this a parseable information. What I wish we did was something like a map[string]string, which could be sorted, serialized, and hashed.
dustin-decker
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We're seeing secrets of this type flap between verified and unverified, which is expected behavior for multipart secrets without
RawV2defined. This PR addsRawV2for secrets of this type.Checklist:
make test-community)?make lintthis requires golangci-lint)?