Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detector-Competition-Feat: Added OpenVPN API Detector #1940

Merged

Conversation

fumblehool
Copy link
Contributor

Description:

This PR adds detector for OpenVpn (https://openvpn.net/) API.
Note: the API is currently in beta.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

How to test

  1. Register for a new account on Cloud Connexa (previously known as openvpn) Cloud using https://myaccount.openvpn.com/signup/cvpn
  2. Once registered, you can follow the developer guilde to get CliendId and Secret (https://openvpn.net/cloud-docs/developer/creating-api-credentials.html)
  3. Once the API is enabled, you'll see the swagger docs within the account.

Running local tests

Screenshot 2023-10-22 at 5 34 00 PM

Getting Credentials

  1. Registering a new account:, the domain will be <account_id>.api.openvpn.com
Screenshot 2023-10-22 at 12 05 29 AM
  1. Enable and create client credentials.
Screenshot 2023-10-22 at 12 07 05 AM

@fumblehool fumblehool requested a review from a team as a code owner October 22, 2023 12:11
@dustin-decker dustin-decker added the Hacktoberfest-Detector-Competition-New Apply this label if you are adding a new detector for the detector competition label Oct 24, 2023
Copy link
Collaborator

@ahrav ahrav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments but otherwise LGTM!
Thanks a lot for all the contributions @fumblehool

pkg/detectors/openvpn/openvpn.go Outdated Show resolved Hide resolved
pkg/detectors/openvpn/openvpn.go Outdated Show resolved Hide resolved
pkg/detectors/openvpn/openvpn.go Outdated Show resolved Hide resolved
pkg/detectors/openvpn/openvpn.go Outdated Show resolved Hide resolved
pkg/detectors/openvpn/openvpn.go Outdated Show resolved Hide resolved
pkg/detectors/openvpn/openvpn.go Outdated Show resolved Hide resolved
@fumblehool fumblehool force-pushed the fumblehool/add-openvpn-detector branch from c7b3c8a to ffb5d6b Compare October 25, 2023 11:05
@fumblehool
Copy link
Contributor Author

@ahrav Updated PR, please merge 😸

@ahrav ahrav merged commit b2702b7 into trufflesecurity:main Oct 25, 2023
7 of 8 checks passed
Phoenix591 pushed a commit to Phoenix591/trufflehog that referenced this pull request Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest-Detector-Competition-New Apply this label if you are adding a new detector for the detector competition
Development

Successfully merging this pull request may close these issues.

3 participants