Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detector-Competition-Feat: Added Portainer Detector #1936

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Detector-Competition-Feat: Added Portainer Detector #1936

merged 2 commits into from
Oct 25, 2023

Conversation

fumblehool
Copy link
Contributor

@fumblehool fumblehool commented Oct 21, 2023 •
edited
Loading

Description:

This PR adds the detector for Portainer Admin (https://www.portainer.io/)
Portainer API documentation: https://docs.portainer.io/api/docs

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

Verification

Screenshot 2023-10-21 at 11 19 29 PM

Testing locally

  1. Run portainer Using Docker : https://docs.portainer.io/start/install-ce/server/docker/linux
  2. Create Admin Account and Get User Jwt token : https://docs.portainer.io/api/examples
  3. Use the Bearer token for testing.

@fumblehool fumblehool requested a review from a team as a code owner October 21, 2023 17:55
@zricethezav
Copy link
Collaborator

@fumblehool this LGTM, just needs conflicts merged

@fumblehool fumblehool force-pushed the fumblehool/add-portainer-detector branch from 0a345a8 to ddc3ec2 Compare October 24, 2023 15:32
@fumblehool
Copy link
Contributor Author

@zricethezav Updated the code, please merge :)

@dustin-decker dustin-decker added the Hacktoberfest-Detector-Competition-New Apply this label if you are adding a new detector for the detector competition label Oct 24, 2023
ahrav
ahrav approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@ahrav ahrav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @fumblehool LGTM!

@ahrav ahrav merged commit 2189dc9 into trufflesecurity:main Oct 25, 2023
7 of 8 checks passed
Phoenix591 pushed a commit to Phoenix591/trufflehog that referenced this pull request Oct 27, 2023
@fumblehool @ahrav @Phoenix591
Detector-Competition-Feat: Added Portainer Detector (trufflesecurity#…
c8a7b5b 
…1936)

Co-authored-by: Ahrav Dutta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrav ahrav ahrav approved these changes

Assignees
No one assigned
Labels
Hacktoberfest-Detector-Competition-New Apply this label if you are adding a new detector for the detector competition
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fumblehool @zricethezav @ahrav @dustin-decker