Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This change appends issue and pr titles to the scan data for
--issue-comments
and--pr-comments
respectively. People apparently share secrets in titles, for instance: https://github.com/coinbase/waas-client-library-go /issues/52 (intentional space to avoid linking).It would be ideal to write test cases for this, however, off the top of my head I'm not sure the best way to test
chunkIssues
andchunkPullRequests
. Unit tests would seemingly require either mockings.visibilityOf()
or rewriting the code.trufflehog/pkg/sources/github/github.go
Lines 1313 to 1335 in 6ea3a7d
Checklist:
make test-community
)?make lint
this requires golangci-lint)?