Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Add SourceUnitEnumChunker filesystem tests #1873

Merged
merged 2 commits into from
Oct 16, 2023
Merged

[chore] Add SourceUnitEnumChunker filesystem tests #1873

merged 2 commits into from
Oct 16, 2023

Conversation

mcastorina
Copy link
Collaborator

Description:

Add tests for the filesystem enumeration and SourceUnit chunking methods.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@mcastorina mcastorina requested review from a team as code owners October 6, 2023 06:53
mcastorina
mcastorina commented Oct 6, 2023
View reviewed changes
pkg/sourcestest/sourcestest.go
@@ -0,0 +1,61 @@
package sourcestest
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure where to put these so I made a sourcestest package akin to iotest. Open to suggestions!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I have a test implementation #1877 but open to this too.

rosecodym
rosecodym approved these changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@rosecodym rosecodym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but it's probably worth getting more votes for your module organization question

pkg/sources/filesystem/filesystem_test.go Show resolved Hide resolved
@mcastorina mcastorina merged commit 03dc7cb into main Oct 16, 2023
9 checks passed
@mcastorina mcastorina deleted the chore-filesystem-source-unit-test branch October 16, 2023 17:42
Phoenix591 pushed a commit to Phoenix591/trufflehog that referenced this pull request Oct 27, 2023
@mcastorina @Phoenix591
[chore] Add SourceUnitEnumChunker filesystem tests (trufflesecurity#1873
d50b686 
)

* [chore] Add SourceUnitEnumChunker filesystem tests

* Ensure reported units are exactly what is expected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustin-decker dustin-decker dustin-decker left review comments

@rosecodym rosecodym rosecodym approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcastorina @dustin-decker @rosecodym