Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] add figmav2 to defaults #1820

Merged
merged 2 commits into from
Sep 28, 2023
Merged

[chore] add figmav2 to defaults #1820

merged 2 commits into from
Sep 28, 2023

Conversation

0x1
Copy link
Contributor

@0x1 0x1 commented Sep 26, 2023

Description:

add figmav2 to defaults

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@0x1 0x1 requested a review from a team as a code owner September 26, 2023 15:10
@0x1 0x1 changed the title add figmav2 to defaults [chore] add figmav2 to defaults Sep 26, 2023
Copy link
Collaborator

@mcastorina mcastorina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

figmapersonalaccesstokenV2 should be replaced with figmapersonalaccesstoken_v2 since the package name should match the directory it's in. Typically Go uses underscores for packages instead of camel case since some filesystems are case insensitive (my theory).

@0x1
Copy link
Contributor Author

0x1 commented Sep 28, 2023

figmapersonalaccesstokenV2 should be replaced with figmapersonalaccesstoken_v2 since the package name should match the directory it's in. Typically Go uses underscores for packages instead of camel case since some filesystems are case insensitive (my theory).

agreed w/ package name should match directory name. but the docs say package names should be lowercase and no mixedCaps or underscores. thoughts?

@0x1
Copy link
Contributor Author

0x1 commented Sep 28, 2023

figmapersonalaccesstokenV2 should be replaced with figmapersonalaccesstoken_v2 since the package name should match the directory it's in. Typically Go uses underscores for packages instead of camel case since some filesystems are case insensitive (my theory).

agreed w/ package name should match directory name. but the docs say package names should be lowercase and no mixedCaps or underscores. thoughts?

apparently the right way to do this is by adding the version to the import path, but keeping the original package name. it's actually pretty clean.

@0x1 0x1 requested a review from mcastorina September 28, 2023 04:04
Copy link
Collaborator

@ahrav ahrav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

@0x1 0x1 merged commit e645827 into main Sep 28, 2023
9 checks passed
@0x1 0x1 deleted the add-figma-to-defaults branch September 28, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants