Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate gitlab detectors #1819

Merged
merged 12 commits into from
Sep 28, 2023
Merged

Separate gitlab detectors #1819

merged 12 commits into from
Sep 28, 2023

Conversation

0x1
Copy link
Contributor

@0x1 0x1 commented Sep 26, 2023

Description:

Update GitlabV1 and GitlabV2 detectors to handle a unique version of secret
Update Gitlab to tri-state verification

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@0x1 0x1 requested review from a team as code owners September 26, 2023 14:56
@0x1 0x1 mentioned this pull request Sep 26, 2023
Closed
2 tasks
rosecodym
rosecodym requested changes Sep 26, 2023
View reviewed changes
pkg/detectors/gitlab/gitlab.go Outdated Show resolved Hide resolved
pkg/detectors/gitlab/gitlab_v1_test.go Outdated Show resolved Hide resolved
pkg/detectors/gitlab/gitlab_v2_test.go Show resolved Hide resolved
pkg/detectors/gitlabV2/gitlab_v1_test.go Outdated Show resolved Hide resolved
@0x1 0x1 requested a review from rosecodym September 26, 2023 18:00
rosecodym
rosecodym approved these changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@rosecodym rosecodym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok well i still don't quite understand why the v1 detector doesn't pick up v2 secrets but the tests pass so that's more of a homework project for me than you. nice work!

@zricethezav zricethezav merged commit 5df6afd into main Sep 28, 2023
9 checks passed
@zricethezav zricethezav deleted the separate-gitlab-detectors branch September 28, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosecodym rosecodym rosecodym approved these changes

@dustin-decker dustin-decker Awaiting requested review from dustin-decker

@trufflesteeeve trufflesteeeve Awaiting requested review from trufflesteeeve

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0x1 @rosecodym @zricethezav