Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github partial scan #1804

Merged
merged 5 commits into from
Sep 26, 2023
Merged

Github partial scan #1804

merged 5 commits into from
Sep 26, 2023

Conversation

ahrav
Copy link
Collaborator

@ahrav ahrav commented Sep 21, 2023

Description:

Include the ability for the Github source to handle partial scans of the source. This allows us to use the metadata for a secret to only scan the chunk the secret was found in. This can be used for efficient revivification of the secret.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@ahrav ahrav mentioned this pull request Sep 21, 2023
2 tasks
@ahrav ahrav marked this pull request as ready for review September 21, 2023 22:33
@ahrav ahrav requested a review from a team as a code owner September 21, 2023 22:33
@ahrav ahrav requested a review from a team September 21, 2023 23:06
Copy link
Collaborator

@mcastorina mcastorina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super cool - just saw one possible edge case

pkg/sources/github/repo.go Outdated Show resolved Hide resolved
@ahrav ahrav merged commit bf47fd6 into main Sep 26, 2023
9 checks passed
@ahrav ahrav deleted the github-partial-scan branch September 26, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants