Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added Web3 Storage detector #1789

Merged
merged 4 commits into from
Sep 27, 2023
Merged

added Web3 Storage detector #1789

merged 4 commits into from
Sep 27, 2023

Conversation

ankushgoel27
Copy link
Contributor

@ankushgoel27 ankushgoel27 commented Sep 20, 2023 •
edited
Loading

Description:

This PR adds a detector to the web3 storage token from https://web3.storage

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@ankushgoel27 ankushgoel27 requested a review from a team as a code owner September 20, 2023 02:04
@ankushgoel27 ankushgoel27 reopened this Sep 20, 2023
@zricethezav zricethezav added the pkg/detectors PRs and Issues related to the `detectors` package label Sep 20, 2023
@zricethezav
Copy link
Collaborator

@ankushgoel27 Can you update the description of this PR please?

zricethezav
zricethezav requested changes Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@zricethezav zricethezav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ankushgoel27 quick regex change otherwise lgtm

pkg/detectors/web3storage/web3storage.go Outdated Show resolved Hide resolved
zricethezav
zricethezav reviewed Sep 27, 2023
View reviewed changes
test Outdated Show resolved Hide resolved
@zricethezav zricethezav merged commit faf4617 into trufflesecurity:main Sep 27, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zricethezav zricethezav zricethezav approved these changes

Assignees
No one assigned
Labels
pkg/detectors PRs and Issues related to the `detectors` package
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ankushgoel27 @zricethezav