Use placeholder as default if field left empty and is required #1642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: mcastorina <[email protected]>
rosecodym
reviewed
Aug 21, 2023
| @@ -49,7 +50,7 @@ func GetTrufflehogConfiguration() truffleCmdModel { | |||
| Key: "concurrency", | |||
| Required: false, | |||
| Help: "Number of concurrent workers.", | |||
| Placeholder: "1", | |||
| Placeholder: strconv.Itoa(runtime.NumCPU()), | |||
There was a problem hiding this comment.
which was the default concurrency before we added the tui stuff?
There was a problem hiding this comment.
The updated version. We copied it from here:
Line 47 in ed06217
rosecodym
approved these changes
Oct 2, 2023
Phoenix591
pushed a commit
to Phoenix591/trufflehog
that referenced
this pull request
Oct 27, 2023
…lesecurity#1642) * Use placeholder as default if field left empty and is required Co-authored-by: mcastorina <[email protected]> * Drop unused func * uncomment azure source * update wording --------- Co-authored-by: mcastorina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
If nothing's been entered for a required field, populate the value with the placeholder value & bug fixes @mcastorina
Checklist:
make test-community)?make lintthis requires golangci-lint)?